Conversation
AksonovSergei
left a comment
AksonovSergei
left a comment
There was a problem hiding this comment.
Please fix my comments before the next meeting. If you can't, I will help you.
KPI_Rover/Buzzer/driver.c
Outdated
| return errors; | ||
| } | ||
|
|
||
| unsigned int Buzzer_Pulse(const unsigned int on_time_ms, const unsigned int period_time_ms, const unsigned int total_active_time_ms) |
There was a problem hiding this comment.
This is a blocking function. If you call it with total_active_time_ms = 5000, it will block the thread that calls it for 5 seconds.
There was a problem hiding this comment.
One more test case from Gemini:
Test Case: Disabling an Active Buzzer
Objective
Verify that the buzzer stops immediately when Buzzer_Disable() is called, even if the Buzzer_Pulse() function is still active.
Steps
Call the Buzzer_Pulse() function with a long duration, for example, total_active_time_ms = 5000.
Wait a short time (e.g., 500 milliseconds) to confirm the buzzer is on.
Call the Buzzer_Disable() function.
Expected Result
The buzzer should turn off right after Buzzer_Disable() is called. The Buzzer_Pulse() function's 5-second timer should be ignored. The device should be silent.
2 participants
No description provided.